From 281016a5014146387e38d268aa271d539fd562e8 Mon Sep 17 00:00:00 2001 From: Wim Date: Sat, 21 Mar 2020 21:27:17 +0100 Subject: Fix duplicate separator on empty description/url (discord). Fixes #1008 (#1035) Make this work for all possible cases. Add tests --- bridge/discord/handlers_test.go | 58 +++++++++++++++++++++++++++++++++++++++++ 1 file changed, 58 insertions(+) create mode 100644 bridge/discord/handlers_test.go (limited to 'bridge/discord/handlers_test.go') diff --git a/bridge/discord/handlers_test.go b/bridge/discord/handlers_test.go new file mode 100644 index 00000000..af821ad0 --- /dev/null +++ b/bridge/discord/handlers_test.go @@ -0,0 +1,58 @@ +package bdiscord + +import ( + "testing" + + "github.com/matterbridge/discordgo" + "github.com/stretchr/testify/assert" +) + +func TestHandleEmbed(t *testing.T) { + testcases := map[string]struct { + embed *discordgo.MessageEmbed + result string + }{ + "allempty": { + embed: &discordgo.MessageEmbed{}, + result: "", + }, + "one": { + embed: &discordgo.MessageEmbed{ + Title: "blah", + }, + result: "embed: blah\n", + }, + "two": { + embed: &discordgo.MessageEmbed{ + Title: "blah", + Description: "blah2", + }, + result: "embed: blah - blah2\n", + }, + "three": { + embed: &discordgo.MessageEmbed{ + Title: "blah", + Description: "blah2", + URL: "blah3", + }, + result: "embed: blah - blah2 - blah3\n", + }, + "twob": { + embed: &discordgo.MessageEmbed{ + Description: "blah2", + URL: "blah3", + }, + result: "embed: blah2 - blah3\n", + }, + "oneb": { + embed: &discordgo.MessageEmbed{ + URL: "blah3", + }, + result: "embed: blah3\n", + }, + } + + for name, tc := range testcases { + assert.Equalf(t, tc.result, handleEmbed(tc.embed), "Testcases %s", name) + } +} -- cgit v1.2.3